Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise on failed inference endpoint in InferenceEndpoint.wait() #1935

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Dec 21, 2023

Originally from @philschmid on slack (internal):

i am working on a IE example with the new version of huggingface_hub which supports custom container image configs. I noticed that .wait will not break if the endpoint failed.
I made a mistake an the endpoint is in the "failed" status through the UI but the endpoint.wait() is still "blocking".

We now raise an error if the inference endpoint gets into a failed state instead of waiting forever.

@Wauplin Wauplin requested a review from philschmid December 21, 2023 15:27
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@philschmid philschmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c2aac6) 82.44% compared to head (456159f) 82.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1935      +/-   ##
==========================================
- Coverage   82.44%   82.42%   -0.03%     
==========================================
  Files          66       66              
  Lines        8138     8140       +2     
==========================================
  Hits         6709     6709              
- Misses       1429     1431       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wauplin
Copy link
Contributor Author

Wauplin commented Jan 8, 2024

Thanks for reviewing!

@Wauplin Wauplin merged commit 66f8ea6 into main Jan 8, 2024
16 checks passed
@Wauplin Wauplin deleted the raise-on-failed-inference-endpoint branch January 8, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants